-
Notifications
You must be signed in to change notification settings - Fork 2
Cookie banner v1 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cookie banner v1 #293
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ddfa41c
Update Store to standard implementation
mjbp d1a21f2
Refactor
mjbp 3d92002
Housekeeping
mjbp 980dcc2
Review docs
mjbp 3c48163
Example CSS
mjbp 978938e
Text casing
mjbp 5273a5d
Fix test
mjbp 17f30e9
Add src to npm package
mjbp 1ee799e
Readme
mjbp b504655
Snagging
mjbp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| .DS_Store | ||
| *.log | ||
| src | ||
| __tests__ | ||
| example | ||
| coverage | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { createStore } from '../src/lib/store'; | ||
|
|
||
| describe(`Cookie banner > Store`, () => { | ||
|
|
||
| const Store = createStore(); | ||
| let effect = false; | ||
| const sideEffect = state => { | ||
| effect = !effect; | ||
| }; | ||
|
|
||
| it('createStore should return an Object with an API', async () => { | ||
| expect(Store).not.toBeNull(); | ||
| expect(Store.getState).not.toBeNull(); | ||
| expect(Store.update).not.toBeNull(); | ||
| }); | ||
|
|
||
| it('should have a getState function that returns a private state Object', async () => { | ||
| expect(Store.state).toBeUndefined(); | ||
| expect(Store.getState()).toEqual({}); | ||
| }); | ||
|
|
||
| it('should have an update function that updates state', async () => { | ||
| const nextState = { isOpen: true }; | ||
| Store.update(nextState); | ||
| expect(Store.getState()).toEqual(nextState); | ||
| }); | ||
|
|
||
| it('should have an update function that does not update state if nextState is not passed', async () => { | ||
| const Store = createStore(); | ||
| Store.update(); | ||
| expect(Store.getState()).toEqual({}); | ||
| }); | ||
|
|
||
| it('should have an update function that invokes any side effect functions passed after the state change, with new null or undefined state', async () => { | ||
| Store.update(null, [sideEffect]); | ||
| expect(effect).toEqual(true); | ||
| }); | ||
|
|
||
|
|
||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking here! But seems to be a small typo, might be clearer to say "The banner should be a polite aria live region"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in regards to the test starting on line 78, just for clarification.