Merged
Conversation
Add custom events
Update code comments
Closed
catvine-stormid
approved these changes
Feb 24, 2025
catvine-stormid
left a comment
catvine-stormid
left a comment
There was a problem hiding this comment.
Looks good, just a few little (potential) typos :)
packages/modal/README.md
Outdated
|
|
||
| ## Options | ||
| Options can be set during initialising in an Object passed as the second argument to the modal function, e.g. `modal('.js-modal', { startOpen: true })`, or as data-attributes on the modal element (the element passed to the modal function), e.g. `data-start-open="true"` | ||
| Options can be set during initialising in an Object passed as the second argument to the modal function, e.g. `modal('.js-modal', { startOpen: true })`, or as data-attributes on the modal element (the element passed to the initiaisation function), e.g. `data-start-open="true"` |
packages/modal/src/lib/dom.js
Outdated
| /* | ||
| * Sets aria attributes and adds eventListener on each tab | ||
| * Partially applied function that returns a function | ||
| * Sets aria attributes and adds eventListener on each nodal toggle |
There was a problem hiding this comment.
Is "nodal toggle" meant to be "modal toggle"?
sarah-richards-stormid
approved these changes
Feb 25, 2025
Contributor
sarah-richards-stormid
left a comment
sarah-richards-stormid
left a comment
There was a problem hiding this comment.
Nothing additional to Cat's comments!
sarah-richards-stormid
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #283