Skip to content

First draft of feature-netapp-trident #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

rbo
Copy link
Member

@rbo rbo commented Jan 30, 2025

#93

Copy link
Collaborator

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rbo rbo force-pushed the feature-netapp-trident branch from 2d9d5c9 to f3af9f1 Compare February 13, 2025 21:29
Copy link
Collaborator

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- name: iscsi.service
enabled: true
- name: multipathd.service
enabled: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On SNO clusters, would this cause a reboot? Then subsequent operations might fail due to the API going down? Maybe wait for the pool to stabilize? Example for that is here:
https://github.com/DanielFroehlich/stormshift-automation/blob/4c216034ef72e5733a1dfabd188f85ac75276a6b/roles/feature-workload-partitioning/tasks/post-deploy.yaml#L32

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uf that's not so easy / time consuming. Because If have to patch master, wait... patch worker, wait...

backendType: "ontap-nas"
provisioningType: "thin"
snapshots: "true"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some wait task here for everything to stabilize and be ready? I could image that this feature is one of the first in the sequence, because subsequent feature like RHOAI need storage, and it would be nice if those then do not fail. Eg. wait for the operator pod to be ready, or some of the Trident CRs maybe report a nice status we could wait for to be reached?

@rbo rbo force-pushed the feature-netapp-trident branch from d7b3c13 to 5c3d436 Compare February 24, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants