-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(common): upgrade eslint #405
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry for the big PR 🙏🏻 |
packages/cli/templates/vue2/src/components/FieldPluginExample/ModalToggle.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eunjae-lee 🙌
massive job 💯
So nice to see most of the eslint comments removed and also to have just one config file to handle everything. 😍
I just noticed some eslint warnings that I guess you will address still
But overall, the PR looks solid so I'll approve it and then you can fix the warnings in your time 🙌
Actually Vue 2 has a bad typescript support, and our vue 2 template is not even using typescript. So I believe we could ignore some warnings in the vue 2 template :) But I will fix other issues if we encounter any in separate PRs. I will merge it for now, so that the other PRs aren't too affected much by this. |
What?
This PR upgrades eslint to v9 which changes the configuration file very much. However, I'm not migrating the previous config exactly as-is. The previous rules are very custom, but I'm suggesting to go back to the recommended config sets by the official packages.
packages/cli/templates/react
has its own eslint config, but it's actually almost the same as the root config. And we're not using that config in our repository. This config will be used when the CLI creates a new React project for users. Vue and Vanilla templates doesn't have eslint config baked in, because the official vite's templates for Vue and Vanilla doesn't include them. And we leave them empty so that people can adapt different linters & configs (https://eslint.style/ or https://biomejs.dev/)Why?
JIRA: SHAPE-7107
How to test? (optional)