Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): upgrade eslint #405

Merged
merged 7 commits into from
Sep 25, 2024
Merged

chore(common): upgrade eslint #405

merged 7 commits into from
Sep 25, 2024

Conversation

eunjae-lee
Copy link
Contributor

What?

This PR upgrades eslint to v9 which changes the configuration file very much. However, I'm not migrating the previous config exactly as-is. The previous rules are very custom, but I'm suggesting to go back to the recommended config sets by the official packages.

  • It's community standard (it can go far until we actually need to tweak it for our own needs)
  • As long as we keep this configs, the code is consistent everywhere.
  • The root eslint config is applied to the whole repository whereas some packages used to have their own eslint config.
  • No need to maintain many instances of eslint dependency and config within the repository.
  • Only one exception here is that packages/cli/templates/react has its own eslint config, but it's actually almost the same as the root config. And we're not using that config in our repository. This config will be used when the CLI creates a new React project for users. Vue and Vanilla templates doesn't have eslint config baked in, because the official vite's templates for Vue and Vanilla doesn't include them. And we leave them empty so that people can adapt different linters & configs (https://eslint.style/ or https://biomejs.dev/)

Why?

JIRA: SHAPE-7107

How to test? (optional)

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 1:38pm

@eunjae-lee
Copy link
Contributor Author

Sorry for the big PR 🙏🏻

Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eunjae-lee 🙌
massive job 💯

So nice to see most of the eslint comments removed and also to have just one config file to handle everything. 😍

I just noticed some eslint warnings that I guess you will address still
image

But overall, the PR looks solid so I'll approve it and then you can fix the warnings in your time 🙌

@eunjae-lee
Copy link
Contributor Author

Hey @eunjae-lee 🙌 massive job 💯

So nice to see most of the eslint comments removed and also to have just one config file to handle everything. 😍

I just noticed some eslint warnings that I guess you will address still image

But overall, the PR looks solid so I'll approve it and then you can fix the warnings in your time 🙌

Actually Vue 2 has a bad typescript support, and our vue 2 template is not even using typescript. So I believe we could ignore some warnings in the vue 2 template :)

But I will fix other issues if we encounter any in separate PRs. I will merge it for now, so that the other PRs aren't too affected much by this.

@eunjae-lee eunjae-lee merged commit 47a8b14 into main Sep 25, 2024
19 checks passed
@eunjae-lee eunjae-lee deleted the SHAPE-7107-upgrade-eslint branch September 25, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants