Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): release @storyblok/[email protected] #450

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Dawntraoz
Copy link
Contributor

What?

JIRA: SHAPE-7913

This PR updates the CLI version for release.

@Dawntraoz Dawntraoz self-assigned this Jan 10, 2025
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:06am

@demetriusfeijoo
Copy link
Contributor

Hey @Dawntraoz 👋

Q: are we also going to add some examples of how to use the modal by setting its width or height in the templates?

@Dawntraoz
Copy link
Contributor Author

Hey @Dawntraoz 👋

Q: are we also going to add some examples of how to use the modal by setting its width or height in the templates?

Since it is optional and is already covered in the docs: https://www.storyblok.com/docs/plugins/field-plugins/storyblok-field-plugin#:~:text=.-,setModalOpen,-Opens/Closes%20the, I thought it was better to keep the templates clean, but let me know if you think is better to add them, happy to do so if needed 🙏

Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is optional and is already covered in the docs: https://www.storyblok.com/docs/plugins/field-plugins/storyblok-field-plugin#:~:text=.-,setModalOpen,-Opens/Closes%20the, I thought it was better to keep the templates clean, but let me know if you think is better to add them, happy to do so if needed 🙏

Makes sense to me too, @Dawntraoz 🙌

Let's gooooo 🚀 🚀

@Dawntraoz Dawntraoz merged commit 240f5e3 into main Jan 10, 2025
19 checks passed
@Dawntraoz Dawntraoz deleted the chore/release-cli-1.5.2 branch January 10, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants