fix: improve loading bottom sheet by using non modal version #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabioatcorreia I'm trying something different since I found that the flatlist didn't have any reasonable perf impact (i think because of complex nested items) I found that scrollview was actually working better (with 200 generated stories) I moved the bottom sheet from a modal style to just a regular component and made some other adjustments that seem to have a bigger impact on perf. Can you try |
|
It's looking great 🚀 storybook-improvement.webm |
|
made some optimizations for rerenders 8.5.2-alpha.3 should be smoother for changing stories etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #667
What I did
flatlist was making things slower so I tried a different approach, turns out the modal version of bottomsheet causes some lag since it has to render everything on demand.
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.