Types: Fix typing issues in addon-test #30164
Conversation
ndelangen
changed the title
|
View your CI Pipeline Execution ↗ for commit 99c6b71.
☁️ Nx Cloud last updated this comment at |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| statusOrder.indexOf(a.status || state.running ? 'pending' : 'unknown') - | ||
| statusOrder.indexOf(b.status || state.running ? 'pending' : 'unknown') |
There was a problem hiding this comment.
logic: operator precedence issue - parentheses needed around ternary to avoid incorrect evaluation
There was a problem hiding this comment.
I suggest extracting state.running ? 'pending' : 'unknown' to a variable for clarity and because it's used twice. This would avoid the need for parenthesis.
|
I'll open a alternative PR to unblock @ghengeveld can you please visit this, and ensure all the types are accurate? Please remove the |
Closes #
What I did
TestResult.results.statusto be undefined in types, which the runtime seems to support.TypeScript was convinced that this could never happen, and so provided an error.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Based on the provided files, I'll create a concise summary of the changes in this PR:
Fixes typing issues in addon-test module by allowing undefined status values in TestResultResult type, aligning TypeScript types with existing runtime behavior.
TestResultResulttype inreporter.tsto support undefined status for failed/warning statesTestProviderRender.tsxstatus mapping and sorting logicmanager.tsxto properly handle undefined test result statusesThe changes appear focused on type definitions rather than runtime behavior changes, making the types match what the code already supports. The key files modified are in the addon-test module and primarily affect type checking rather than functionality.