Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
N/A. Storage was added in #28.
Description of changes
The setup workflow's
hoist-allvariant still selects components 1–7, so it silently removes Storage (component 8) instead of exercising its renamed exports and tests. Include Storage in both languages' all-component selection, and explicitly check that its source and test files are retained there and removed in the existing tool/plugin-only subset.No setup-script or runtime behavior changes, and no new matrix jobs.
Testing
Extracted and executed the workflow's updated setup commands and generated-project check commands in disposable copies on macOS arm64, using Python 3.10.19 and Node.js 22.22.2:
hoist-all: all 12 tests pass, including 4 Storage tests; format, lint, and mypy pass.subset: both tests pass; format, lint, and mypy pass.hoist-all: all 11 tests pass; format, lint, type checks, and build pass.subset: all 3 tests pass; format, lint, type checks, and build pass.git diff --checkpasses.GitHub-hosted Ubuntu execution was not reproduced locally. No AWS resources, model calls, or GPU were used. The existing TypeScript dependency tree reports npm audit advisories; dependencies are unchanged by this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.