Skip to content

Display alert if volume key missing or status unknown #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 25, 2025

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jun 17, 2025

@mulkieran mulkieran self-assigned this Jun 17, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from 6a203ef to 84ca983 Compare June 18, 2025 01:28
@mulkieran mulkieran added this to the v3.8.2 milestone Jun 18, 2025
@mulkieran mulkieran moved this to In Progress in 2025June Jun 18, 2025
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from 36a68a7 to b0c395d Compare June 18, 2025 17:24
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from b0c395d to 5d46240 Compare June 18, 2025 18:06
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from 9b7b35c to e14e5c2 Compare June 18, 2025 20:36
@mulkieran
Copy link
Member Author

It is odd that we calculate the device size change codes separately.

@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from e14e5c2 to 87f9f54 Compare June 18, 2025 21:08
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch 3 times, most recently from 2493312 to 7806cb3 Compare June 23, 2025 12:51
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch 2 times, most recently from 7aa0254 to c8e4b3f Compare June 23, 2025 19:55
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch 2 times, most recently from 3a5937b to 2962617 Compare June 23, 2025 21:07
@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from 2962617 to 5c743aa Compare June 23, 2025 22:16
@mulkieran mulkieran changed the title Update introspection information Display alert if volume key missing or status unknown Jun 24, 2025
@mulkieran mulkieran marked this pull request as ready for review June 24, 2025 13:01
@mulkieran mulkieran moved this from In Progress to In Review in 2025June Jun 24, 2025
@mulkieran mulkieran requested a review from jbaublitz June 24, 2025 13:01
@mulkieran
Copy link
Member Author

/packit build

@jbaublitz jbaublitz self-requested a review June 24, 2025 14:47
Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to leave that review as a comment.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratis-cli-1172
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratis-cli-1172
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the issue-stratisd-3810 branch from 39adb41 to 3eceae4 Compare June 25, 2025 15:32
@mulkieran
Copy link
Member Author

mulkieran commented Jun 25, 2025

Help text for explain has a few added codes, the WC ones:

# PYTHONPATH=./src ./bin/stratis pool explain --help
usage: stratis pool explain [-h] {WS001,IDS001,WDS002,WC001,WC002,EM001,EM002}

positional arguments:
  {WS001,IDS001,WDS002,WC001,WC002,EM001,EM002}
                        Error code to explain

options:
  -h, --help            show this help message and exit

Explain text for the added codes:

# PYTHONPATH=./src ./bin/stratis pool explain WC001
The pool's volume key is not loaded. This may result in an error if the pool's encryption layer needs to be modified. If the pool is encrypted with a key in the kernel keyring then setting that key may resolve the problem.

and for a very unlikely possibility:

# PYTHONPATH=./src ./bin/stratis pool explain WC002
The pool's volume key may or may not be loaded. If the volume key is not loaded, there may an error if the pool's encryption layer needs to be modified.

Pool detail view with alert set:

# PYTHONPATH=./src ./bin/stratis pool list --name pn
UUID: 6b569179-9ca2-4619-ba06-4679ab53357c
Name: pn
Alerts: 1
     WC001: Volume key not loaded
Metadata Version: 2
Actions Allowed: fully_operational
Cache: No
Filesystem Limit: 100
Allows Overprovisioning: Yes
Encryption Enabled: Yes
    Free Token Slots Remaining: 14
    Token Slot: 0
        Clevis Pin: tang
        Clevis Configuration: {'thp': 'Wei3wSEdZNUrvYqJiv8I0JoAOZZK-SegVwHmI7w97JQ', 'url': 'http://127.0.0.1'}
Fully Allocated: No
    Size: 50 GiB
    Allocated: 50.00 GiB
    Used: 1.46 GiB

and pool table view:

# PYTHONPATH=./src ./bin/stratis pool list
Name             Total / Used / Free        Properties                                   UUID   Alerts
pn     50 GiB / 1.46 GiB / 48.54 GiB   ~Le,~Ca, Cr, Op   45171b8a-d6f9-49a8-bda3-1439f7934593   WC001 

@mulkieran
Copy link
Member Author

/packit build

@mulkieran mulkieran requested a review from drckeefe June 25, 2025 15:43
@mulkieran
Copy link
Member Author

COPR is too busy to build right now. We shouldn't let that stop us.

@mulkieran mulkieran merged commit 7a58f80 into stratis-storage:master Jun 25, 2025
10 of 13 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025June Jun 25, 2025
@mulkieran mulkieran deleted the issue-stratisd-3810 branch June 25, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants