Skip to content

Disable ENABLE_BROWSER_QT_LOOP #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Disable ENABLE_BROWSER_QT_LOOP #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f0cd6
rename obs64 helper -> OBS helper
sandboxcoder May 28, 2025
c638d28
fix browser source configuration for macos
sandboxcoder May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmake/os-macos.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
find_package(Qt6 REQUIRED Widgets)
# We currently do not use Qt in obs-studio-node so its' best to leave this off. OBS.app is a QtApplication so this makes sense for them.
#find_package(Qt6 REQUIRED Widgets)

target_compile_definitions(obs-browser PRIVATE ENABLE_BROWSER_SHARED_TEXTURE ENABLE_BROWSER_QT_LOOP)
# Do not turn on ENABLE_BROWSER_QT_LOOP. Once again, obs-studio-node is not a Qt app. We could make it one kinda easily as long as the exact same
# binaries we use to build obs-browser is packed up and shipped along like libobs.framework. But for now we dont need the ENABLE_BROWSER_QT_LOOP flag
target_compile_definitions(obs-browser PRIVATE ENABLE_BROWSER_SHARED_TEXTURE)

if(CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 14.0.3)
target_compile_options(obs-browser PRIVATE -Wno-error=unqualified-std-cast-call)
Expand All @@ -10,7 +13,7 @@ target_link_libraries(obs-browser PRIVATE Qt::Widgets CEF::Wrapper "$<LINK_LIBRA
"$<LINK_LIBRARY:FRAMEWORK,AppKit.framework>")

set(helper_basename browser-helper)
set(helper_output_name "obs64 Helper")
set(helper_output_name "obs64 Helper") # See cef_types.h documentation for browser_subprocess_path setting
set(helper_suffixes "::" " (GPU):_gpu:.gpu" " (Plugin):_plugin:.plugin" " (Renderer):_renderer:.renderer")

foreach(helper IN LISTS helper_suffixes)
Expand Down