Skip to content

Support custom scrape configs #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuteng wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support custom scrape configs #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10be91c
Support custom scrape configs
tuteng Sep 26, 2025
5c5db4c
Support custom scrape configs
tuteng Sep 26, 2025
3a2fd3d
Merge branch 'master' into fixed/support-use-custom-scrape-configs
tuteng Jan 12, 2026
1fe0f19
Support disable kubenetes node and cadvisor scrape
tuteng Jan 12, 2026
6b20aa3
Fixed
tuteng Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion charts/sn-platform-slim/templates/prometheus/prometheus-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ data:
path_prefix: {{ template "pulsar.control_center_path.alertmanager" . }}/
{{- end }}
scrape_configs:
{{- if .Values.prometheus.customScrapeConfigs -}}
{{- with .Values.prometheus.customScrapeConfigs }}
{{ toYaml . | indent 4 }}
{{- end }}
{{- else }}
- job_name: 'prometheus'
static_configs:
- targets:
Expand Down Expand Up @@ -107,7 +112,7 @@ data:
{{ toYaml . | indent 6 }}
{{- end }}
{{- end }}
{{- if .Values.prometheus.serviceAccount.clusterRole }}
{{- if and .Values.prometheus.serviceAccount.clusterRole (or (not (hasKey .Values.prometheus.scrape "kubernetesNodes")) (eq .Values.prometheus.scrape.kubernetesNodes true)) }}
- job_name: 'kubernetes-nodes'
scheme: https
kubernetes_sd_configs:
Expand All @@ -126,6 +131,8 @@ data:
regex: (.+)
target_label: __metrics_path__
replacement: /api/v1/nodes/${1}/proxy/metrics
{{- end }}
{{- if and .Values.prometheus.serviceAccount.clusterRole (or (not (hasKey .Values.prometheus.scrape "kubernetesCadvisor")) (eq .Values.prometheus.scrape.kubernetesCadvisor true)) }}
- job_name: 'kubernetes-cadvisor'
scheme: https
kubernetes_sd_configs:
Expand Down Expand Up @@ -154,6 +161,7 @@ data:
{{- with .Values.prometheus.extraCustomArgs }}
{{ toYaml . | indent 4 }}
{{- end }}
{{- end }}
{{- end }}
rules.yml: |
{{- if .Values.monitoring.alert_manager -}}
Expand Down
1 change: 1 addition & 0 deletions charts/sn-platform-slim/templates/prometheus/pulsar-operators-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ rules:
resources:
- nodes
- nodes/proxy
- nodes/metrics
- services
- endpoints
- pods
Expand Down
5 changes: 5 additions & 0 deletions charts/sn-platform-slim/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,6 +1951,10 @@ prometheus:
node_exporter: true
proxy: true
zookeeper: true
# Enable scraping of kubernetes nodes metrics
kubernetesNodes: true
# Enable scraping of kubernetes cadvisor metrics
kubernetesCadvisor: true
# nodeSelector:
# cloud.google.com/gke-nodepool: default-pool
labels: {}
Expand Down Expand Up @@ -2026,6 +2030,7 @@ prometheus:
customRelabelConfigs: []
extraScrapeConfigs: []
extraCustomArgs: {}
customScrpaConfigs: []

## Prometheus service
## templates/prometheus-service.yaml
Expand Down
10 changes: 9 additions & 1 deletion charts/sn-platform/templates/prometheus/prometheus-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ data:
path_prefix: {{ template "pulsar.control_center_path.alertmanager" . }}/
{{- end }}
scrape_configs:
{{- if .Values.prometheus.customScrapeConfigs -}}
{{- with .Values.prometheus.customScrapeConfigs }}
{{ toYaml . | indent 4 }}
{{- end }}
{{- else }}
- job_name: 'prometheus'
static_configs:
- targets:
Expand Down Expand Up @@ -107,7 +112,7 @@ data:
{{ toYaml . | indent 6 }}
{{- end }}
{{- end }}
{{- if .Values.prometheus.serviceAccount.clusterRole }}
{{- if and .Values.prometheus.serviceAccount.clusterRole (or (not (hasKey .Values.prometheus.scrape "kubernetesNodes")) (eq .Values.prometheus.scrape.kubernetesNodes true)) }}
- job_name: 'kubernetes-nodes'
scheme: https
kubernetes_sd_configs:
Expand All @@ -126,6 +131,8 @@ data:
regex: (.+)
target_label: __metrics_path__
replacement: /api/v1/nodes/${1}/proxy/metrics
{{- end }}
{{- if and .Values.prometheus.serviceAccount.clusterRole (or (not (hasKey .Values.prometheus.scrape "kubernetesCadvisor")) (eq .Values.prometheus.scrape.kubernetesCadvisor true)) }}
- job_name: 'kubernetes-cadvisor'
scheme: https
kubernetes_sd_configs:
Expand Down Expand Up @@ -154,6 +161,7 @@ data:
{{- with .Values.prometheus.extraCustomArgs }}
{{ toYaml . | indent 4 }}
{{- end }}
{{- end }}
{{- end }}
rules.yml: |
{{- if .Values.monitoring.alert_manager -}}
Expand Down
1 change: 1 addition & 0 deletions charts/sn-platform/templates/prometheus/pulsar-operators-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ rules:
resources:
- nodes
- nodes/proxy
- nodes/metrics
- services
- endpoints
- pods
Expand Down
6 changes: 6 additions & 0 deletions charts/sn-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,6 +2032,10 @@ prometheus:
proxy: true
zookeeper: true
vault: true
# Enable scraping of kubernetes nodes metrics
kubernetesNodes: true
# Enable scraping of kubernetes cadvisor metrics
kubernetesCadvisor: true
# nodeSelector:
# cloud.google.com/gke-nodepool: default-pool
labels: {}
Expand Down Expand Up @@ -2107,6 +2111,8 @@ prometheus:
customRelabelConfigs: []
extraScrapeConfigs: []
extraCustomArgs: {}
# A advanced configuration to add custom scrape configs.
customScrapeConfigs: []

## Prometheus service
## templates/prometheus-service.yaml
Expand Down
Loading