Feature advanced search #2067
Open
Feature advanced search #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
force-pushed
the
feature-advanced-search-
branch
from
f5508c1 to
7069673
Compare
thecodrr
requested changes
Mar 6, 2023
Comment on lines
220
to
223
| back: { | ||
| title: `Go back to ${type}`, | ||
| title: `Go back to test`, | ||
| action: () => window.history.back() | ||
| } |
There was a problem hiding this comment.
This button should be removed.
Comment on lines
-55
to
+58
| "eslint-plugin-header": "^3.1.1" | ||
| "eslint-plugin-header": "^3.1.1", | ||
| "liqe": "^3.6.0", | ||
| "react-datepicker": "^4.10.0", | ||
| "react-fast-compare": "^3.2.0" |
There was a problem hiding this comment.
What are these libraries doing here? This is the global package.json.
| ml={1} | ||
| sx={{ textOverflow: "ellipsis" }} | ||
| > | ||
| {props.item.main2} |
| ml={1} | ||
| sx={{ textOverflow: "ellipsis" }} | ||
| > | ||
| {props.item.main1} |
| setResults(results); | ||
| })(); | ||
| }, [nonce, type, context]); | ||
| useEffect(() => {}, []); |
|
|
||
| if (!title) return hardNavigate("/"); | ||
| const type = "notes"; |
|
|
||
| return ( | ||
| <> | ||
| <Text variant="subtitle" mx={2}> | ||
| Searching {title} | ||
| Searching {type} |
Comment on lines
+101
to
+122
| <Flex mx={2}> | ||
| {results.map((result, index) => | ||
| result.length > 0 ? ( | ||
| <Button | ||
| variant="tertiary" | ||
| sx={{ | ||
| borderColor: | ||
| index === selectedResult ? "primary" : undefined | ||
| }} | ||
| mr={1} | ||
| onClick={() => { | ||
| setSearchItem(result); | ||
| setSelectedResult(index); | ||
| }} | ||
| > | ||
| {`${result[0].type}s`} | ||
| </Button> | ||
| ) : ( | ||
| [] | ||
| ) | ||
| )} | ||
| </Flex> |
Comment on lines
+123
to
134
| {searchItem.length > 0 ? ( | ||
| <SearchResults | ||
| title={capitalizeFirstLetter(`${searchItem[0].type}s`)} | ||
| context={context} | ||
| type={`${searchItem[0].type}s`} | ||
| results={searchItem} | ||
| ></SearchResults> | ||
| ) : ( | ||
| <Text variant="subtitle" mx={2}> | ||
| {"No items to show"} | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
This can already be done via ListContainer. No need to reinvent the wheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.