web: don't remove properties pane when editor is refocused #7780
Conversation
01zulfi
force-pushed
the
web-beta/toggle-properties-on-request-focus
branch
from
24b3a7b to
f664c61
Compare
01zulfi
changed the title
apps/web/src/stores/editor-store.ts
Outdated
| if (toggleTableOfContents !== false) { | ||
| this.toggleTableOfContents(false); | ||
| } |
There was a problem hiding this comment.
In what case we want to toggle table of contents with properties? I think this can be removed as it's not needed anymore. There is a dedicated function to toggle TOC already which should be used. The fact that this did no affect any other code shows it isn't used anywhere in the repo.
There was a problem hiding this comment.
Whenever properties is toggled, it closes the table of contents, this ensures that only one pane is open at a time
There was a problem hiding this comment.
Let's keep the existing behavior from the stable app and:
- If you open TOC, it should close properties if already opened
- If you close properties, do nothing with the TOC.
- If you open properties, do nothing with the TOC.
From what I can tell, it is a bug in the beta app because the stable version behaves correctly (it doesn't close properties on opening TOC though which we should fix here). The TOC never closes unless you close it by clicking X.
There was a problem hiding this comment.
Just trying the beta app again, it seems that the UI has changed quite a bit and now properties and TOC are part of the editor, not floating on top. Both show in the same container, are they stacked on top or replaced?
There was a problem hiding this comment.
They are separate panes
There was a problem hiding this comment.
@ammarahm-ed do let me know what needs to be done
| onRequestFocus: () => { | ||
| toggleProperties(false, false); | ||
| }, |
There was a problem hiding this comment.
Instead of all these changes, let's just remove this "close on focus" logic altogether.
01zulfi
force-pushed
the
web-beta/toggle-properties-on-request-focus
branch
from
f664c61 to
cfcb08a
Compare
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
web-beta/toggle-properties-on-request-focus
branch
from
cfcb08a to
7fa4860
Compare
01zulfi
changed the title
Signed-off-by: 01zulfi [email protected]
Closes #7770