Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support streamlined consent pane in FC #10350

Closed
wants to merge 2 commits into from
Closed

Support streamlined consent pane in FC #10350

wants to merge 2 commits into from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼──────────┬──────────┬───────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff      
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
      dex │   4.1 MiB │   4.1 MiB │ +6.5 KiB │    9 MiB │  9.1 MiB │ +13.4 KiB 
     arsc │   2.4 MiB │   2.4 MiB │      0 B │  2.4 MiB │  2.4 MiB │       0 B 
 manifest │   5.2 KiB │   5.2 KiB │      0 B │ 25.7 KiB │ 25.7 KiB │       0 B 
      res │ 909.3 KiB │ 909.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │    +40 B │  1.6 MiB │  1.6 MiB │     +40 B 
    other │   1.4 MiB │   1.4 MiB │    +16 B │  1.6 MiB │  1.6 MiB │       0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
    total │  12.9 MiB │  12.9 MiB │ +6.5 KiB │ 22.1 MiB │ 22.2 MiB │ +13.4 KiB 

 DEX     │ old   │ new   │ diff                
─────────┼───────┼───────┼─────────────────────
   files │     1 │     1 │   0                 
 strings │ 42812 │ 42858 │ +46 (+3466 -3420)   
   types │ 15362 │ 15386 │ +24 (+3438 -3414)   
 classes │ 12968 │ 12991 │ +23 (+2717 -2694)   
 methods │ 62757 │ 62836 │ +79 (+24178 -24099) 
  fields │ 41759 │ 41816 │ +57 (+19164 -19107) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6274 │ 6274 │  0
APK 
     compressed      │     uncompressed      │                                            
──────────┬──────────┼───────────┬───────────┤                                            
 size     │ diff     │ size      │ diff      │ path                                       
──────────┼──────────┼───────────┼───────────┼────────────────────────────────────────────
  4.1 MiB │ +6.5 KiB │   9.1 MiB │ +13.4 KiB │ ∆ classes.dex                              
    127 B │   +127 B │       5 B │      +5 B │ + META-INF/services/S9.x                   
    127 B │   +127 B │       5 B │      +5 B │ + META-INF/services/T9.a                   
          │   -127 B │           │      -5 B │ - META-INF/services/R9.y                   
          │   -127 B │           │      -5 B │ - META-INF/services/S9.a                   
  8.1 KiB │    +26 B │     8 KiB │     +26 B │ ∆ assets/dexopt/baseline.prof              
    1 KiB │    +14 B │     921 B │     +14 B │ ∆ assets/dexopt/baseline.profm             
 50.6 KiB │    +14 B │ 119.9 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                     
    168 B │     +3 B │      10 B │       0 B │ ∆ META-INF/services/java.security.Provider 
  1.2 KiB │     -1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                        
──────────┼──────────┼───────────┼───────────┼────────────────────────────────────────────
  4.2 MiB │ +6.5 KiB │   9.2 MiB │ +13.4 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   42812 │ 42858 │ +46 (+3466 -3420) 
  
  + , logoState=
  + , moreInfoNotice=
  + , onLogoPress=null, logoState=
  + , streamlinedConsent=
  + LA6/c;
  + LA6/d;
  + LA6/e;
  + LA6/f;
  + LA6/g;
  + LA6/h;
  + LA6/i;
  + LA7/A0;
  + LA7/A1;
  + LA7/B0;
  + LA7/B1;
  + LA7/C0;
  + LA7/C1;
  + LA7/D0;
  + LA7/D1;
  + LA7/E0;
  + LA7/E1;
  + LA7/F0;
  + LA7/F1;
  + LA7/G0;
  + LA7/G1;
  + LA7/H0;
  + LA7/H1;
  + LA7/I0;
  + LA7/I1;
  + LA7/J0;
  + LA7/J1;
  + LA7/K0;
  + LA7/K1;
  + LA7/L0;
  + LA7/L1;
  + LA7/M0;
  + LA7/M1;
  + LA7/N0;
  + LA7/N1;
  + LA7/O0;
  + LA7/O1;
  + LA7/P0;
  + LA7/P1;
  + LA7/Q0;
  + LA7/Q1;
  + LA7/R0;
  + LA7/R1;
  + LA7/S0;
  + LA7/S1;
  + LA7/T0;
  + LA7/T1;
  + LA7/U0;
  + LA7/U1;
  + LA7/V0;
  + LA7/V1;
  + LA7/W0;
  + LA7/W1;
  + LA7/X0;
  + LA7/X1;
  + LA7/Y0;
  + LA7/Y1;
  + LA7/Z0;
  + LA7/Z1;
  + LA7/a1;
  + LA7/a2;
  + LA7/b1;
  + LA7/b2;
  + LA7/c1;
  + LA7/c2;
  + LA7/d1;
  + LA7/d2;
  + LA7/e1;
  + LA7/e2;
  + LA7/f1;
  + LA7/f2;
  + LA7/g1;
  + LA7/g2;
  + LA7/h1;
  + LA7/h2;
  + LA7/i1;
  + LA7/i2;
  + LA7/j1;
  + LA7/j2;
  + LA7/k1;
  + LA7/k2;
  + LA7/l1;
  + LA7/l2;
  + LA7/m1;
  + LA7/m2;
  + LA7/n1;
  + LA7/n2;
  + LA7/o1;
  + LA7/o2;
  + LA7/p1;
  + LA7/q1;
  + LA7/r1;
  + LA7/s1;
  + LA7/t1;
  + LA7/u1;
  + LA7/v1;
  + LA7/w1;
  + LA7/x1;
  + LA7/y1;
  + LA7/z0;
  + LA7/z1;
  + LA8/e;
  + LA8/f;
  + LA8/g;
  + LA8/h;
  + LA8/i;
  + LA8/j;
  + LA8/k;
  + LA8/l;
  + LA9/b;
  + LB5/N;
  + LB5/O;
  + LB5/P;
  + LB5/Q;
  + LB5/S;
  + LB5/T;
  + LB5/U;
  + LB7/A;
  + LB7/B;
  + LB7/C;
  + LB7/D;
  + LB7/E;
  + LB7/F;
  + LB7/G;
  + LB7/H;
  + LB7/I;
  + LB7/J;
  + LB7/K;
  + LB7/L;
  + LB7/M;
  + LB7/N;
  + LB7/O;
  + LB7/P;
  + LB7/Q;
  + LB7/S;
  + LB7/T;
  + LB7/U;
  + LB7/V;
  + LB7/W;
  + LB7/X;
  + LB7/Y;
  + LB7/Z;
  + LB7/a0;
  + LB7/b0;
  + LB7/c0;
  + LB7/d0;
  + LB7/e0;
  + LB7/f0;
  + LB7/f;
  + LB7/g0;
  + LB7/g;
  + LB7/h0;
  + LB7/h;
  + LB7/i0;
  + LB7/i;
  + LB7/j0;
  + LB7/j;
  + LB7/k0;
  + LB7/k;
  + LB7/l;
  + LB7/m;
  + LB7/n;
  + LB7/o;
  + LB7/p;
  + LB7/q;
  + LB7/r;
  + LB7/s;
  + LB7/t;
  + LB7/u;
  + LB7/v;
  + LB7/w;
  + LB7/x;
  + LB7/y;
  + LB7/z;
  + LB9/a;
  + LC5/D;
  + LC6/d;
  + LC6/e;
  + LC6/f;
  + LC6/g;
  + LC6/h;
  + LC6/i;
  + LC8/A;
  + LC8/B;
  + LC8/C;
  + LC8/D;
  + LC8/E;
  + LC8/F;
  + LC8/G;
  + LC8/H;
  + LC8/I;
  + LC8/J;
  + LC8/K;
  + LC8/L;
  + LC8/M;
  + LC8/b;
  + LC8/c;
  + LC8/d;
  + LC8/e;
  + LC8/f;
  + LC8/g;
  + LC8/h;
  + LC8/i;
  + LC8/j;
  + LC8/k;
  + LC8/l;
  + LC8/m;
  + LC8/n;
  + LC8/o;
  + LC8/p;
  + LC8/q;
  + LC8/r;
  + LC8/s;
  + LC8/t;
  + LC8/u;
  + LC8/v;
  + LC8/w;
  + LC8/x;
  + LC8/y;
  + LC8/z;
  + LD7/b;
  + LD7/c;
  + LD7/d;
  + LD7/e;
  + LD7/f;
  + LD7/g;
  + LD7/h;
  + LD7/i;
  + LD7/j;
  + LD7/k;
  + LD7/l;
  + LD7/m;
  + LD7/n;
  + LD7/o;
  + LD7/p;
  + LD7/q;
  + LD7/r;
  + LD7/s;
  + LD7/t;
  + LD7/u;
  + LD7/v;
  + LD7/w;
  + LD7/x;
  + LDa/a;
  + LDa/b;
  + LDa/c;
  + LDa/d;
  + LE6/r;
  + LE6/s;
  + LE6/t;
  + LE6/u;
  + LE6/v;
  + LE6/w;
  + LE8/b;
  + LE8/c;
  + LE8/d;
  + LE8/e;
  + LE8/f;
  + LE8/g;
  + LE8/h;
  + LE8/i;
  + LE8/j;
  + LE8/k;
  + LE8/l;
  + LE8/m;
  + LE8/n;
  + LE8/o;
  + LE8/p;
  + LE8/q;
  + LE8/r;
  + LE8/s;
  + LE8/t;
  + LE8/u;
  + LE8/v;
  + LE8/w;
  + LF6/j;
  + LF6/k;
  + LF6/l;
  + LF6/m;
  + LF6/n;
  + LF6/o;
  + LF6/p;
  + LF6/q;
  + LFa/e;
  + LFa/f;
  + LFa/g;
  + LFa/h;
  + LFa/i;
  + LFa/j;
  + LFa/k;
  + LFa/l;
  + LFa/m;
  + LFa/n;
  + LFa/o;
  + LFa/p;
  + LFa/q;
  + LG7/b;
  + LG7/c;
  + LG7/d;
  + LG7/e;
  + LG7/f;
  + LG7/g;
  + LG7/h;
  + LG7/i;
  + LG7/j;
  + LG7/k;
  + LG8/b;
  + LG8/c;
  + LG8/d;
  + LG8/e;
  + LG8/f;
  + LG8/g;
  + LG8/h;
  + LG8/i;
  + LH6/P;
  + LH6/Q;
  + LH6/S;
  + LH6/T;
  + LH6/U;
  + LH6/V;
  + LHa/d;
  + LHa/e;
  + LI5/H;
  + LI5/I;
  + LI6/A;
  + LI6/B;
  + LI6/C;
  + LI6/D;
  + LI6/E;
  + LI6/F;
  + LI6/G;
  + LI6/H;
  + LI6/I;
  + LI6/J;
  + LI6/K;
  + LI6/L;
  + LI6/M;
  + LI6/N;
  + LI6/O;
  + LI6/c;
  + LI6/d;
  + LI6/e;
  + LI6/f;
  + LI6/g;
  + LI6/h;
  + LI6/i;
  + LI6/j;
  + LI6/k;
  + LI6/l;
  + LI6/m;
  + LI6/n;
  + LI6/o;
  + LI6/p;
  + LI6/q;
  + LI6/r;
  + LI6/s;
  + LI6/t;
  + LI6/u;
  + LI6/v;
  + LI6/w;
  + LI6/x;
  + LI6/y;
  + LI6/z;
  + LI7/D;
  + LI7/E;
  + LI7/F;
  + LI7/G;
  + LI7/H;
  + LI7/I;
  + LI7/J;
  + LI7/K;
  + LI7/L;
  + LI7/M;
  + LI7/N;
  + LI7/O;
  + LI7/P;
  + LI7/Q;
  + LI7/S;
  + LI7/T;
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/fc-support-streamlined-consent branch from 75da1b1 to e55cc01 Compare March 7, 2025 16:57
@tillh-stripe tillh-stripe force-pushed the tillh/fc-support-streamlined-consent branch from e55cc01 to 23bb2d8 Compare March 7, 2025 17:04
@tillh-stripe
Copy link
Collaborator Author

Replaced by #10397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tillh-stripe