Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft CustomPaymentMethod API #10379

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Mar 12, 2025

Summary

Draft CustomPaymentMethod API

Motivation

Add a draft of the API defined in API Review doc in order to work on custom payment methods support.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe added the custom-payment-methods Related to Custom Payment Methods project label Mar 12, 2025
Copy link
Contributor

github-actions bot commented Mar 12, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.4 KiB │   7.4 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.2 KiB │  95.2 KiB │ -6 B │ 182.4 KiB │ 182.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -6 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20144 │ 20144 │ 0 (+0 -0) 
   types │  6235 │  6235 │ 0 (+0 -0) 
 classes │  5026 │  5026 │ 0 (+0 -0) 
 methods │ 30045 │ 30045 │ 0 (+0 -0) 
  fields │ 17388 │ 17388 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
   29 KiB │ -5 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.7 KiB │ +1 B │    64 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 55.8 KiB │ -6 B │ 129.3 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch 2 times, most recently from 1a12930 to 6397b53 Compare March 12, 2025 17:53
@samer-stripe
Copy link
Collaborator Author

I don't except this API to change much from the API review doc. Want to add portions of the API so that work on the straightforward internals can begin (fetching from elements/session, rendering, confirmation)

@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch from 6397b53 to 7caf41c Compare March 12, 2025 18:21
@samer-stripe samer-stripe marked this pull request as ready for review March 12, 2025 18:51
@samer-stripe samer-stripe requested review from a team as code owners March 12, 2025 18:51
@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch from 7caf41c to 8268686 Compare March 14, 2025 16:56
@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch from 8268686 to df1063b Compare March 17, 2025 15:36
@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch from df1063b to 0f76735 Compare March 17, 2025 16:03
@samer-stripe samer-stripe force-pushed the samer/draft-custom-payment-methods-api branch from 0f76735 to 9e058b6 Compare March 17, 2025 16:21
@samer-stripe samer-stripe merged commit 21d2d3a into master Mar 17, 2025
13 checks passed
@samer-stripe samer-stripe deleted the samer/draft-custom-payment-methods-api branch March 17, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-payment-methods Related to Custom Payment Methods project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants