Skip to content

Add content description for lock icon on Set Up button #12201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gosling-dude wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Add content description for lock icon on Set Up button #12201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paymentsheet/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ to be saved and used in future checkout sessions. -->
<string name="stripe_something_went_wrong">Something went wrong</string>
<!-- Accessibility description when payment button shows a successful transaction animation. -->
<string name="stripe_successful_transaction_description">Transaction complete</string>
<string name="stripe_secure_icon">Secure icon</string>
<!-- Button text on a screen asking the user to approve a payment -->
<string name="stripe_upi_polling_cancel">Cancel and pay another way</string>
<!-- Text on a screen asking the user to approve a payment -->
Expand Down
3 changes: 3 additions & 0 deletions paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PrimaryButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ internal class PrimaryButton @JvmOverloads constructor(
viewBinding.label.setViewCompositionStrategy(
ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed
)

viewBinding.lockIcon.contentDescription = context.getString(R.string.stripe_secure_icon)

getTextAttributeValue(attrs)?.let {
setLabel(it.toString().resolvableString)
}
Expand Down