Repository navigation
Confirm before discarding Address Element changes - #14848
Draft
cttsai-stripe wants to merge 1 commit into
Draft
cttsai-stripe wants to merge 1 commit into
cttsai-stripe wants to merge 1 commit into
Conversation
2 of 3 tasks
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 9, 2026 23:51
9beadcd to
62a76bc
Compare
cttsai-stripe
changed the base branch from
master
to
cttsai/address-element-discard-dialog-sae
October 9, 2026 23:51
cttsai-stripe
added this pull request to stack #14979
October 9, 2026 23:51
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 15, 2026 17:58
1e5e3cb to
2ae44c7
Compare
cttsai-stripe
removed this pull request from stack #14979
October 15, 2026 23:07
cttsai-stripe
added this pull request to stack #15031
October 15, 2026 23:07
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 15, 2026 23:08
2ae44c7 to
ceef91b
Compare
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
2 times, most recently
from
October 16, 2026 05:15
58c6d86 to
7778347
Compare
cttsai-stripe
removed this pull request from stack #15031
October 16, 2026 05:30
cttsai-stripe
added this pull request to stack #15035
October 16, 2026 05:31
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 16, 2026 05:34
7778347 to
65e3b94
Compare
cttsai-stripe
removed this pull request from stack #15035
October 16, 2026 16:58
cttsai-stripe
added this pull request to stack #15040
October 16, 2026 16:58
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 16, 2026 17:01
65e3b94 to
6cd21d1
Compare
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
6 times, most recently
from
October 16, 2026 18:28
801f2bc to
f1304e7
Compare
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 16, 2026 18:52
f1304e7 to
720e19f
Compare
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 19, 2026 17:45
720e19f to
f36d451
Compare
Base automatically changed from
cttsai/address-element-discard-dialog-sae
to
master
October 19, 2026 21:42
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
cttsai-stripe
force-pushed
the
cttsai/address-element-discard-dialog
branch
from
October 19, 2026 21:42
f36d451 to
bd0d0c1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]
Summary
Address Element asks before dismissal when rendered address input or the visible custom checkbox differs from its initial state. Unchanged or reverted input cancels directly. This applies to both standalone Address Element and Shipping Address Element.
Motivation
Replace #14978's SAE launch-mode condition with actual edit detection, including checkbox-only edits to match iOS.
AddressFormControllercompares rendered inputs, andInputAddressViewModeladds the visible checkbox state; the existing result-state holder handles confirmation and cancellation.The Activity queries the input destination's existing ViewModel for each dismissal attempt, preserving its navigation scope and autocomplete result subscription.
Testing
Local checks passed: 116 tests across
AddressElementActivityTest,AddressElementActivityAnalyticsTest,AddressFormControllerTest, andInputAddressViewModelTest. These cover edit detection and reversion, dismissal across both launch modes, keeping edits, discarding, and recreation. No emulator checks for this revision.Screenshots
Uses the dialog renderer and six appearance/theme snapshots from #14978.
Changelog
Committed and created by Codex.