Repository navigation
Share Address Element appearance across screens - #15039
Merged
Merged
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
2 of 3 tasks
cttsai-stripe
added this pull request to stack #15040
October 16, 2026 16:58
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
toluo-stripe
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address Element now applies its configured appearance to the entire sheet, including autocomplete. The Activity owns one
PaymentElementThemeshared by the sheet and its navigation destinations.Motivation
The form previously applied its own scoped theme while the surrounding sheet and autocomplete used a system-selected theme. A shared owner keeps forced light/dark appearance consistent and lets the dismissal dialog in #14978 inherit the same theme.
Decisions
Flow
flowchart TD Activity[AddressElementActivity: PaymentElementTheme] --> Sheet[ElementsBottomSheetLayout] Sheet --> Form[InputAddressScreen] Sheet --> Autocomplete[AutocompleteScreen]Testing
Added one Activity regression for forced dark appearance on a light system, and moved existing form screenshot themes to their callers. Source review and
git diff --checkcompleted. Tests were not run locally; validation uses CI. The pre-push hook is bypassed to use CI for validation.Screenshots
Existing form screenshot baselines are retained.
Changelog
No entry: theme mode is guarded by
@RestrictTo(LIBRARY_GROUP); ordinary appearance values are preserved.Committed and created by Codex.