Copy StripePaymentsUI images into StripePaymentSheet#5969
Draft
davidme-stripe wants to merge 2 commits intomasterfrom
Draft
Copy StripePaymentsUI images into StripePaymentSheet#5969davidme-stripe wants to merge 2 commits intomasterfrom
davidme-stripe wants to merge 2 commits intomasterfrom
Conversation
1 build increased size, 2 builds decreased size, 5 builds had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
| Other | ⬇️ -2.1 kB |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
No changes to report
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 356 B
Total download size change: ⬇️ 2.6 kB (-0.13%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
| Other | ⬇️ -2.1 kB |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 111.3 kB (0.9%)
Total download size change: ⬆️ 81.5 kB (1.91%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Packed Asset | ⬆️ 0 B |
| Other | ⬆️ 9.8 kB |
| 📝 icon-card-unionpay.svg (Vector) | ⬆️ 5.5 kB |
| 📝 icon-card-discover.svg (Vector) | ⬆️ 2.4 kB |
| 📝 cvcAmexLight.svg (Vector) | ⬆️ 2.2 kB |
View Treemap
StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize
No changes to report
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
No changes to report
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
No changes to report
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all use of STPImageLibrary from StripePaymentSheet. Duplicate any images used across both StripePaymentsUI and StripePaymentSheet.
Motivation
Removing StripePaymentSheet's dependency on StripePaymentsUI
Testing
CI, added PaymentSheetImageLibraryTests.
Changelog
N/A