Bring CardBrandView into StripePaymentSheet #5971
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: STPStringUtils.swift:207 warning: Property 'expirationDateStringRegex' is unused
STPStringUtils.swift:214 warning: Function 'expirationDateString(from:)' is unused
STPStringUtils.swift:244 warning: Property 'stringMayContainExpirationDateRegex' is unused
STPStringUtils.swift:253 warning: Function 'stringMayContainExpirationDate(_:)' is unused
STPStringUtils.swift:262 warning: Property 'slashFormattedExpirationDateRegex' is unused
STPStringUtils.swift:269 warning: Function 'sanitizedExpirationDateFromOCRString(_:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with [find-dead-code] |
davidme-stripe
changed the base branch from
davidme/move-ps-images
to
davidme/move-ps-string-utils
davidme-stripe
force-pushed
the
davidme/move-ps-string-utils
branch
from
391cc83 to
4ec2b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog