Remove StripePaymentSheet's dependency on StripePaymentsUI#5973
Draft
davidme-stripe wants to merge 4 commits intodavidme/cardbrandviewfrom
Draft
Remove StripePaymentSheet's dependency on StripePaymentsUI#5973davidme-stripe wants to merge 4 commits intodavidme/cardbrandviewfrom
davidme-stripe wants to merge 4 commits intodavidme/cardbrandviewfrom
Conversation
davidme-stripe
changed the title
1 build increased size, 3 builds decreased size, 4 builds had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Localizable.strings | ⬇️ -4.1 kB |
| 🗑 StripePaymentsUI.String | ⬇️ -2.8 kB |
| 🗑 StripePaymentsUI.DropdownFieldElement | ⬇️ -1.9 kB |
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.4 kB (0.03%)
Total download size change: ⬆️ 1.2 kB (0.1%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 1.4 kB |
View Treemap
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 20.7 kB (-0.33%)
Total download size change: ⬇️ 27.3 kB (-1.41%)
Largest size changes
| Item | Install Size Change |
|---|---|
| Localizable.strings | ⬇️ -4.1 kB |
| 🗑 StripePaymentsUI.String | ⬇️ -2.8 kB |
| 🗑 StripePaymentsUI.DropdownFieldElement | ⬇️ -1.9 kB |
| Other | ⬆️ 1.8 kB |
| Packed Asset | ⬇️ 0 B |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 930.6 kB (-7.52%)
Total download size change: ⬇️ 296.9 kB (-6.95%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 Stripe_StripePaymentsUI.bundle | ⬇️ -376.8 kB |
| 🗑 StripePaymentsUI | ⬇️ -354.0 kB |
| Packed Asset | ⬆️ 0 B |
| DYLD.Exports | ⬇️ -34.0 kB |
| Code Signature | ⬇️ -12.7 kB |
View Treemap
StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize
No changes to report
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
No changes to report
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
Copies card brand and other payment-related images to StripePaymentSheet and creates PaymentSheetImageLibrary to replace STPImageLibrary usage.
Moves string utility functions from StripePaymentsUI to StripePaymentSheet.
Moves CardBrandView from StripePaymentsUI to StripePaymentSheet.
Removes StripePaymentsUI imports and updates Package.swift and project references.
davidme-stripe
force-pushed
the
davidme/remove-stripepaymentsui-dep
branch
from
1d94b50 to
a9bdfd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog