Skip to content

Conversation

@tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

🚨 New dead code detected in this PR:

AddressSectionElement.swift:127 warning: Unused property 'addressSection'
AddressSectionElement.swift:214 warning: Unused parameter 'title'

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

[find-dead-code]

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

⚠️ Public API changes detected:

StripePaymentSheet

- public init(defaultValues: StripePaymentSheet.AddressViewController.Configuration.DefaultAddressDetails = .init(), additionalFields: StripePaymentSheet.AddressViewController.Configuration.AdditionalFields = .init(), allowedCountries: [Swift.String] = [], appearance: StripePaymentSheet.PaymentSheet.Appearance = PaymentSheet.Appearance.default, buttonTitle: Swift.String? = nil, title: Swift.String? = nil)
+ public init(defaultValues: StripePaymentSheet.AddressViewController.Configuration.DefaultAddressDetails = .init(), additionalFields: StripePaymentSheet.AddressViewController.Configuration.AdditionalFields = .init(), allowedCountries: [Swift.String] = [], appearance: StripePaymentSheet.PaymentSheet.Appearance = PaymentSheet.Appearance.default, separatorStyle: StripePaymentSheet.AddressViewController.SeparatorDisplayStyle = .divider, buttonTitle: Swift.String? = nil, title: Swift.String? = nil)
+ public typealias SeparatorDisplayStyle = StripeUICore.SeparatorDisplayStyle

StripeUICore

+ case divider
+ case spacing(CoreFoundation.CGFloat)

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/address-element-separator-style branch from 6c5e526 to 9bbc134 Compare January 22, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants