Skip to content

CryptoOnramp SDK: Remove authenticateUser API#6036

Merged
mliberatore merged 5 commits intomasterfrom
mliberatore/crypto-onramp-remove-authenticate-user
Feb 4, 2026
Merged

CryptoOnramp SDK: Remove authenticateUser API#6036
mliberatore merged 5 commits intomasterfrom
mliberatore/crypto-onramp-remove-authenticate-user

Conversation

@mliberatore
Copy link
Collaborator

@mliberatore mliberatore commented Feb 3, 2026

Summary

Removes the authenticateUser API, as well as its associated return type, and other references to it. After this is merged, it will also be removed from the API review document (referenced below).

Motivation

Comments and questions on 2026-01-13 - CryptoOnramp SDK (Mobile API Review) Gated GA have led to an understanding that this API is not needed, that OAuth scopes will be required to authenticate (which is possible via the authorize API).

Testing

The code in question was not in use in the codebase, so to test, I simply built the project and ensured tests passed.

Changelog

It sounds like we'll need to provide some detail for release, since we're removing an API.

@mliberatore mliberatore requested review from a team as code owners February 3, 2026 19:53
@mliberatore mliberatore marked this pull request as draft February 3, 2026 19:53
@mliberatore mliberatore changed the title Remove authenticateUser API from CryptoOnrampCoordinator CryptoOnramp SDK: Remove authenticateUser API Feb 3, 2026
@mliberatore mliberatore marked this pull request as ready for review February 3, 2026 20:23
mats-stripe
mats-stripe previously approved these changes Feb 3, 2026
@mats-stripe mats-stripe dismissed their stale review February 3, 2026 21:11

Sorry, before merging could we update the CHANGELOG with a note of this deprecation?

@mats-stripe
Copy link
Collaborator

I think we could add something like this to CHANGELOG.md:

### CryptoOnramp (Beta)
* [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authenticateUserWithToken()`.

@mliberatore
Copy link
Collaborator Author

I think we could add something like this to CHANGELOG.md:

### CryptoOnramp (Beta)
* [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authenticateUserWithToken()`.

Oops, updated CHANGELOG before I saw your reply. I’ll tweak it to match yours exactly.

@mliberatore
Copy link
Collaborator Author

I think we could add something like this to CHANGELOG.md:

### CryptoOnramp (Beta)
* [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authenticateUserWithToken()`.

Oops, updated CHANGELOG before I saw your reply. I’ll tweak it to match yours exactly.

Actually, the "replacement" API should be authorize, not the seamless sign-in API. I’ll add the "(Beta)" designation from your suggestion, though.


### CryptoOnramp (Beta)
* [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authorize()`.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is in the "pending release" section. LMK if I should move it to today's release, but note that there's no rush for me to merge this before the release is made.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it's too late for today's release

mats-stripe
mats-stripe previously approved these changes Feb 3, 2026

### CryptoOnramp (Beta)
* [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authorize()`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it's too late for today's release

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

✅ Dead code has been resolved in this PR.

[find-dead-code]

@mliberatore
Copy link
Collaborator Author

Merge conflict resolution in CHANGELOG.md triggered a review dismissal. Would you mind re-approving @mats-stripe?

@mliberatore mliberatore enabled auto-merge (squash) February 4, 2026 16:04
@mliberatore mliberatore merged commit e2415f2 into master Feb 4, 2026
7 checks passed
@mliberatore mliberatore deleted the mliberatore/crypto-onramp-remove-authenticate-user branch February 4, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants