CryptoOnramp SDK: Remove authenticateUser API#6036
Conversation
authenticateUser API
Sorry, before merging could we update the CHANGELOG with a note of this deprecation?
|
I think we could add something like this to CHANGELOG.md: |
Oops, updated CHANGELOG before I saw your reply. I’ll tweak it to match yours exactly. |
Actually, the "replacement" API should be |
|
|
||
| ### CryptoOnramp (Beta) | ||
| * [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authorize()`. | ||
|
|
There was a problem hiding this comment.
Note that this is in the "pending release" section. LMK if I should move it to today's release, but note that there's no rush for me to merge this before the release is made.
There was a problem hiding this comment.
LGTM! I think it's too late for today's release
|
|
||
| ### CryptoOnramp (Beta) | ||
| * [Removed] Removed `CryptoOnrampCoordinator.authenticateUser()` in favor of `CryptoOnrampCoordinator.authorize()`. | ||
|
|
There was a problem hiding this comment.
LGTM! I think it's too late for today's release
|
✅ Dead code has been resolved in this PR. [find-dead-code] |
|
Merge conflict resolution in |
Summary
Removes the
authenticateUserAPI, as well as its associated return type, and other references to it. After this is merged, it will also be removed from the API review document (referenced below).Motivation
Comments and questions on 2026-01-13 - CryptoOnramp SDK (Mobile API Review) Gated GA have led to an understanding that this API is not needed, that OAuth scopes will be required to authenticate (which is possible via the
authorizeAPI).Testing
The code in question was not in use in the codebase, so to test, I simply built the project and ensured tests passed.
Changelog
It sounds like we'll need to provide some detail for release, since we're removing an API.