Support linking with SDL2 2.0.10 (Ubuntu Focal). #1587
Conversation
|
Focal is EOL, there is no need to put effort into it IMHO. |
I know (it's still in Ubuntu Pro support though) but unfortunately I still didn't get to update one of my dev machines yet so I looked into the recent linker errors. |
For security patches only, not supporting the most modern libs... The changes around SDL2main are interesting though. 👍 |
fancycode
force-pushed
the
sdl2-focal
branch
from
13e4544 to
d01bfcb
Compare
fancycode
force-pushed
the
sdl2-focal
branch
from
d01bfcb to
ae66715
Compare
| common.h) | ||
| target_link_libraries(heif-view PRIVATE heif SDL2::SDL2main SDL2::SDL2) | ||
| target_link_libraries(heif-view PRIVATE heif) | ||
| target_include_directories(heif-view PRIVATE ${libheif_SOURCE_DIR}) |
There was a problem hiding this comment.
Why is this new explicit addition needed? AFAICT, the heif target should already carry over its include path definitions... Is something not working?
There was a problem hiding this comment.
This got removed in 56e85c0 in the switch to the SDL2 components but is there for the other example apps, so I figured it might have been removed by accident.
There was a problem hiding this comment.
it might have been removed by accident
It looks like it indeed, but it shouldn't be needed IMHO. It'd be interesting to see if it could also be removed elsewhere in a separate commit...
The introduction of different components like
SDL2::SDL2/SDL2::SDL2mainhappened in libsdl-org/SDL@dd1d8ab (2.0.12).Also use detection code from https://wiki.libsdl.org/SDL2/README-cmake to figure out when to link against
SDL2::SDLmain.Only tested on different versions of Ubuntu, so more testing on Windows should be done before merging.