Skip to content

Inline-block with conditional IE support - #242

Open
zsitro wants to merge 2 commits into
stylus:masterfrom
zsitro:patch-1
Open

Inline-block with conditional IE support#242
zsitro wants to merge 2 commits into
stylus:masterfrom
zsitro:patch-1

Conversation

@zsitro

@zsitro zsitro commented Feb 9, 2014

Copy link
Copy Markdown

A snippet that I miss in every project where I use nib. If opacity has place here, then inline-block also should be there

/*
 * Inline-block with conditional IE support.
 */
display(mode, args...)
  if mode == 'inline-block'
    display inline-block args
    if support-for-ie
      zoom 1
      *display inline args
  else
    display mode args

@zsitro

zsitro commented Mar 4, 2014

Copy link
Copy Markdown
Author

@visionmedia does it look good?

@notslang

notslang commented Mar 7, 2014

Copy link
Copy Markdown
Collaborator

looks like a good idea, except it needs additional tests.

@zsitro

zsitro commented Apr 12, 2014

Copy link
Copy Markdown
Author

What do you mean @slang800 ? What use-cases are not covered in current test?

@notslang

Copy link
Copy Markdown
Collaborator

Unless I'm totally misunderstanding this PR; We are adding a new mixin that adds properties when we enable support for IE & have display: inline-block. So, there should be a test that makes sure that those properties actually get added.

btw, couldn't the code be refactored into something like this:

display(mode, args...)
  display mode args
  if mode == 'inline-block' && support-for-ie
    // target IE w/ star hack: http://www.ejeliot.com/blog/63
    *zoom 1
    *display inline args

...and should we be putting an * before zoom: 1 too so it only targets IE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants