Inline-block with conditional IE support - #242
Open
zsitro wants to merge 2 commits into
Open
Conversation
Author
|
@visionmedia does it look good? |
Collaborator
|
looks like a good idea, except it needs additional tests. |
Author
|
What do you mean @slang800 ? What use-cases are not covered in current test? |
Collaborator
|
Unless I'm totally misunderstanding this PR; We are adding a new mixin that adds properties when we enable support for IE & have btw, couldn't the code be refactored into something like this: display(mode, args...)
display mode args
if mode == 'inline-block' && support-for-ie
// target IE w/ star hack: http://www.ejeliot.com/blog/63
*zoom 1
*display inline args...and should we be putting an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A snippet that I miss in every project where I use nib. If
opacityhas place here, theninline-blockalso should be there