Apply code suggestions

styrix560 · Jun 1, 2024 · be02e50 · be02e50
1 parent 66f0959
commit be02e50
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/integration_test/app_test.dart b/integration_test/app_test.dart
@@ -161,7 +161,7 @@ Future<void> main() async {
 }
 
 Future<void> wait([int seconds = 5]) async {
-  await Future.delayed(Duration(seconds: seconds));
+  await Future.delayed(Duration(seconds: seconds), () {});
 }
 
 Future<void> clickSeat(WidgetTester tester, String seatText) async {

diff --git a/lib/widgets/seat_cell.dart b/lib/widgets/seat_cell.dart
@@ -6,7 +6,6 @@ import "../types/booking_time.dart";
 import "../types/global_data.dart";
 import "../types/price_type.dart";
 import "../types/seat.dart";
-import "../utils.dart";
 
 class SeatCellWidget extends HookWidget {
   const SeatCellWidget(
@@ -25,26 +24,26 @@ class SeatCellWidget extends HookWidget {
     final seat = Seat(y, x);
     final globalData = GlobalData.fromTime(bookingTime);
     final activeBooking = globalData.activeBooking.value;
-    final rebuild = useRebuild();
-    final previousBooking = useRef<Booking?>(null);
+    // final rebuild = useRebuild();
+    // final previousBooking = useRef<Booking?>(null);
     useListenable(globalData.activeBooking);
     useListenable(globalData.bookings);
 
-    bool shouldRebuild() {
-      final prevBooking = previousBooking.value?.copy();
-      previousBooking.value = activeBooking?.copy();
-
-      bool isActive(Booking? booking) => booking?.seats.contains(seat) ?? false;
-      final isActiveNow = isActive(activeBooking);
-      final wasActiveBefore = isActive(prevBooking);
-      if (isActiveNow != wasActiveBefore) return true;
-      if (!isActiveNow) return false;
-
-      return activeBooking!.seats.length != prevBooking!.seats.length ||
-          activeBooking.lastName != prevBooking.lastName ||
-          activeBooking.pricePaid != prevBooking.pricePaid ||
-          activeBooking.priceType != prevBooking.priceType;
-    }
+    // bool shouldRebuild() {
+    //   final prevBooking = previousBooking.value?.copy();
+    //   previousBooking.value = activeBooking?.copy();
+    //
+    //   bool isActive(Booking? booking) => booking?.seats.contains(seat) ?? false;
+    //   final isActiveNow = isActive(activeBooking);
+    //   final wasActiveBefore = isActive(prevBooking);
+    //   if (isActiveNow != wasActiveBefore) return true;
+    //   if (!isActiveNow) return false;
+    //
+    //   return activeBooking!.seats.length != prevBooking!.seats.length ||
+    //       activeBooking.lastName != prevBooking.lastName ||
+    //       activeBooking.pricePaid != prevBooking.pricePaid ||
+    //       activeBooking.priceType != prevBooking.priceType;
+    // }
 
     Color getColor() {
       Color getColorForBooking(