Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed navbar #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed navbar #178

wants to merge 1 commit into from

Conversation

saadgibawa
Copy link

Description

Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.
Earlier the navbar scrolled up with the page content, making it unavailable when users scroll down. I fixed that issue and it is now fixed on scroll

image

Related Issue

Fixes #58

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel Vercel
Copy link

vercel bot commented Oct 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bio-branch-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 11:52am

@saadgibawa
Copy link
Author

@subhadipbhowmik Please review the changes and let me know if any further changes are required

@subhadipbhowmik subhadipbhowmik added gssoc-ext GSSoc Extended hacktoberfest-accepted Hactober Fest 2024 level1 GSSoc Extended Level 1 Points hacktoberfest Hactober Fest 2024 labels Oct 13, 2024
@saadgibawa
Copy link
Author

saadgibawa commented Oct 15, 2024 •
edited
Loading

@subhadipbhowmik Please assign me this PR, merge it, and then close both the PR and the related issue #58 .

saadgibawa added a commit to saadgibawa/Open-source-Practice that referenced this pull request Nov 9, 2024
@saadgibawa
Create saadgi-pr.md
03514e1 
Hey! Please review my pr 

[Level 1]
subhadipbhowmik/bio-branch#178

[Level 1]
Anjaliavv51/Retro#68
@saadgibawa saadgibawa mentioned this pull request Nov 9, 2024
Merged
@aslams2020
Copy link

This PR has been merged by the GSSoC team
here - sanjay-kv/Open-source-Practice#1428

Don't add labels to it now.You'll get the points in the leaderboard update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gssoc-ext GSSoc Extended hacktoberfest Hactober Fest 2024 hacktoberfest-accepted Hactober Fest 2024 level1 GSSoc Extended Level 1 Points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Header Fixed on Scroll
3 participants
@saadgibawa @aslams2020 @subhadipbhowmik