-
Notifications
You must be signed in to change notification settings - Fork 3.7k
added EKL syntax #9233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
added EKL syntax #9233
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,18 @@ | ||||||
| { | ||||||
| "schema_version": "3.0.0", | ||||||
| "packages": [ | ||||||
| { | ||||||
| "details": "https://github.com/kaessajidi/ekl-sublim-text", | ||||||
| "name": "Dassault Systemes EKL Syntax", | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Language support packages don't need to have "syntax" or something like it in the name, since typically it does more than just the syntax: in your case it also provides completions (which you might want to specify in the labels). If you want to call it Dassault Systemes EKL and not just EKL, it should go into the d.json file instead, an in alphabetical order there.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
You missed this point I'm afraid.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👋🏻 your PR is not mergeable in its current state. |
||||||
| "author": "Kamal Essa", | ||||||
| "labels": ["language syntax"], | ||||||
| "releases": [ | ||||||
| { | ||||||
| "sublime_text": "*", | ||||||
| "tags": true | ||||||
| } | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| "details": "https://github.com/glyph/E-Max", | ||||||
| "releases": [ | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.