Skip to content

Conversation

@mburknoe
Copy link

  • [YES ] I'm the package's author and/or maintainer.
  • [YES ] I have have read [the docs][1].
  • [ YES, though it's the first] I have tagged a release with a [semver][2] version number.
  • [ YES] My package repo has a description and a README describing what it's for and how to use it.
  • [ YES] My package doesn't add context menu entries. *
  • [ YES] My package doesn't add key bindings. **
  • [N/A] Any commands are available via the command palette.
  • [N/A] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • [ TRUE ] If my package is a syntax it doesn't also add a color scheme. ***
  • [ DONE IN PATCH 1.0.1, I didn't know this was a thing! thx.] I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is an alternative to the existing "Cisco Syntax Highlighter". The existing one has not been updated in 7 years, and really doesn't do anything so I have never used it as a CCIE Cisco Engineer and over my career been frustrated by the lack of Cisco Syntax in Sublime

Mine will be active and I'll address recomendations from users.

},
{
"name": "CiscoSyntax BadWifi",
"details": "https://github.com/badwifi/CiscoSyntax-Badwifi-Sublime-syntax",
Copy link
Collaborator

@braver braver Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your repo does not seem to exist at that URL (looks like this might be the one: https://github.com/mburknoe/CiscoSyntax-Badwifi-Sublime-syntax).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you have the right one, Not sure how I made that mistake. I appreciate you fixing it.

Did you think that the proposed name is appropriate or should I name it something else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually just replace the existing package and use its name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that alot, would you let me to try the pull request again, or do you have it covered?

If we replace the existing one using the same name, what does that do to all of the users that already have the existing one installed?

@braver
Copy link
Collaborator

braver commented Dec 18, 2025

If that is indeed the correct URL, we could replace the existing entry with yours. If that's ok with @tunnelsup, that would give everyone 1 up to date syntax package for this use case.

@braver braver added feedback provided The changes and package have been seen by a reviewer takeover Package ownership is changing labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer takeover Package ownership is changing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants