feat(spark): build and publish multi-variant targets#707
Draft
andrew-coleman wants to merge 3 commits intosubstrait-io:mainfrom
Draft
feat(spark): build and publish multi-variant targets#707andrew-coleman wants to merge 3 commits intosubstrait-io:mainfrom
andrew-coleman wants to merge 3 commits intosubstrait-io:mainfrom
Conversation
WIP Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
Adds support for building/publishing multiple targets for different versions of scala (2.12, 2.13) and spark (3.4, 3.5, 4.0). Other combinations can be added in the future. Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
6330a71 to
9216c45
Compare
There are a number of Spark API breaking changes between 3.x and 4.x. This commit refactors the code to abstract affected API calls into a compatibility interface which can be implemented by each version. Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
9216c45 to
414c257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the framework to build and publish multiple Substrait Spark packages targeted at different versions of Scala and Spark.
This is a large PR, however, no functional changes are made. It is split into three commits:
lpadandrpadhad to be added because the Spark 4.0.2 query planner/optimizer inserted them for many of the TPCDS queries. Thedialect.yamlwas regenerated accordingly.2.12and2.13.3.4,3.5and4.0.spark34_2.12,spark35_2.12andspark40_2.13