fix(sysgo): support SP1_PROVER=cluster in verifier and mock mode#340
Open
fakedev9999 wants to merge 1 commit intoop-succinct-sysgofrom
Open
fix(sysgo): support SP1_PROVER=cluster in verifier and mock mode#340fakedev9999 wants to merge 1 commit intoop-succinct-sysgofrom
fakedev9999 wants to merge 1 commit intoop-succinct-sysgofrom
Conversation
… mode resolveSP1VerifierAddr() only checked NETWORK_PRIVATE_KEY to decide between MockVerifier and real PlonkVerifier. In cluster mode (SP1_PROVER=cluster), there is no NETWORK_PRIVATE_KEY, so the test harness deployed MockVerifier even when the cluster produces real Plonk proofs. This caused assert(false) reverts on L2OO submission. Similarly, the mock mode defaulting logic set OP_SUCCINCT_MOCK=true unless NETWORK_PRIVATE_KEY was set, conflicting with cluster mode. Both conditions now also check SP1_PROVER=cluster.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
When running E2E tests with self-hosted cluster proving (SP1_PROVER=cluster), the test harness deployed SP1MockVerifier and set OP_SUCCINCT_MOCK=true because it only checked NETWORK_PRIVATE_KEY to detect real proving mode. This caused:
Test plan