Closed
Conversation
5 tasks
Member
Author
|
Superseded by new PR with corrected S3 artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sp1-sdkfrom5.0.0tov6.0.0(git dependency) and updateartifacts.rsfor async SDK APIforge fmtacross all contracts for consistent formattingcontracts/README.mdoverview to reflect current architectureVerification Results
The following checks were run against the regenerated artifacts:
00byte"v6.0.0""v6.0.0-rc.1"; replaced in both filesVerifier; renamed toGroth16VerifierverifyProofthis.Verify(); changed tothis.verifyProof()0xbb1a6f29..., Groth16:0xc7f26b1b...Key Values
0xbb1a6f2930e94bfe8b35e794faf43133214534a17d2ad8e51358cad437b3c3170xc7f26b1bf195b7e1a9bde70e92d1014a520ba06fe9e27a069d57c8abdad351890x008cd56e10c2fe24795cff1e1d1f40d3a324528d315674da45d26afb376e8670"v6.0.0"Test plan
cargo run --bin artifacts --releasesucceedsforge buildcompiles cleanlyforge fmt --checkpassesforge testpasses (16/16 tests)Supersedes #66.