Add support for quick keys - #5
Open
simonminer wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @suellybelly,
Here's an eleventh hour PR to add support for the quick keys @dorlync set out. Specifically:
Elements need to be focusable for the quick keys to work on them. Right now, the application only contains a subset of the elements supported by quick keys (headings, links, and a single list), but these appear to work properly.
Specific changes to support quick keys include the following.
build/assets/js/modules/quick-key.js- JS class to represent a single quick keybuild/assets/js/modules/quick-key-manager.js- JS clas to manage a set of quick keysbuild/assets/js/quick-key-setup.js- JS module to load quick keys listed above.<script>tag tobuild/index.htmlto load the quick keys into the application.FYI - the files listed above were copied from a separate repo I've been working on to generalize the Inclusiville simulated screen reader.
Hope this feature can be added before the project is submitted. Thanks.