Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the search bar ui #3822

Closed
wants to merge 1 commit into from

Conversation

Haile-08
Copy link

@Haile-08 Haile-08 commented Mar 15, 2024

Fixed Issue #3804

Behavior Before Fix

Currently , on clicking the search bar in the website , a new search box is created which is slightly larger than the original search box and overlaps with the pre-existing one , which does not look very useful or necessary in the UI.

orginal.webm

Behavior After Fix

Remove the current functionality of creating a new search box and use the existing default search box to search blocks. If the size doesn't seem sufficient , the increase of the size of the entire left palette can be proposed.

fix.webm

Edited File Location

MUSICBLOCKS
├── CSS
│   ├── activities.css

Edited Code

#search[type="text"] {
  width: 80px;
  box-sizing: border-box;
  position: absolute;
  background-color: white;
  background-repeat: no-repeat;
  padding: 6px 10px 6px 10px;
  -webkit-transition: width 0.4s ease-in-out;
  transition: width 0.4s ease-in-out;
  font-size: 16px;
  margin-top: 4px;
  color: black;
}

#search:focus {
  border: 1px solid #87cefa;
  border-radius: 1px;
}

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

@pikurasa
Copy link
Collaborator

The search doesn't seem to work for me. And it is more important that the search works than having it look nice...

Screenshot from 2024-03-15 12-18-36
Screenshot from 2024-03-15 12-18-31
Screenshot from 2024-03-15 12-18-23

Are you able to make it both look nice and work?

@Haile-08
Copy link
Author

the functionality was not implemented but i will work on it :)

@Haile-08
Copy link
Author

@pikurasa should I create an issue or work on this branch?

@pikurasa
Copy link
Collaborator

Whereas work for this is continuing on #3829, I am closing this PR. Reopen if I am mistaken.

@pikurasa pikurasa closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants