-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Music Keyboard to Action Conversion Sync #4262
base: master
Are you sure you want to change the base?
Conversation
@MostlyKIGuess It works. But there is one more thing I found. There is a delay (1125 ms) after each note played which is set specifically. Our goal is to make the widget sound the same as the blocks so that users can get a proper idea of how it will fill like when they export it to the action block. |
If we don't edit the time, for shorter notes like 1/16 it will play very fast and a significant difference can be seen. |
@pikurasa What do you think? Changing the timeout value to 1000 should be fine I guess. fixifix.mp4 |
Absolutely, I will change it. |
nice work bro 👊 |
@pikurasa Do review, this is done as discussed in the matrix channel. |
Summary
This PR addresses the issue where notes in the action block are 2.6666666665 times longer than those played in the MusicKeyboard. It applies a scale factor to each note's duration before generating the fraction, ensuring the durations match their original lengths.
Changes
Code Snippet
Testing
Video: