Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner Search UI #4278

Closed
wants to merge 1 commit into from
Closed

Conversation

FirePheonix
Copy link
Contributor

@FirePheonix FirePheonix commented Jan 15, 2025

Issue

fixes-#3804

The search UI's positioning was uneven, plus the border looked unclean and a bit out of place.

Since an extra border was there, the animation seemed much abrupt.

Music Blocks - Google Chrome 15-01-2025 20_00_10

After fix

Music Blocks - Google Chrome 15-01-2025 20_22_37

@AliyanA1
Copy link
Contributor

Hey @FirePheonix ,

I noticed the changes you made, but I believe there’s room for improvement in the current implementation.

The removal of the upper border has, unfortunately, impacted the overall design balance. The border served an important purpose in maintaining visual clarity and separating the SearchBar from surrounding elements, which is especially important for a platform like Music Blocks, aimed at children.

My implementation retained the border while refining the width and color, ensuring a cleaner, more cohesive look without disrupting usability. Removing the border entirely makes the UI feel less structured and may reduce the user-friendliness for kids, who benefit from clear visual boundaries.

I’d love to hear your thoughts on how we can collaboratively refine this further while keeping child-friendly design principles in mind! 😊

@omsuneri
Copy link
Contributor

@walterbender I didn't like the change here what do you think btw

@FirePheonix
Copy link
Contributor Author

@AliyanA1 @omsuneri

I felt like the left portion of bar looked kind of untidy.
But now that I'm observing it closely, you guys are right about it. The no-border DOES look a bit visually cluttered for children.

@omsuneri
Copy link
Contributor

@FirePheonix it's weird to see something like that

@FirePheonix FirePheonix deleted the CleanerSearchUI branch January 15, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants