Fastapi Logic for Pippy Fixes#1 #12
Conversation
Signed-off-by: Chihurumnaya Ibiam <[email protected]>
|
I mentioned you in #9, I'm guessing you haven't taken a look, please do and make the necessary changes to that PR as there's some changes there already. Your use of |
|
Yes, his implemented code misses the LCEL chain and some other functionalities. I'll make those changes soon. |
|
@chimosky , can you tell me if any other modification is required in this code? Then, I can open a PR to the Qixiang Branch. |
| agent.setup_vectorstore(document_paths) | ||
|
|
||
| # Define API routes | ||
| @app.get("/") | ||
| @router.get("/") |
There was a problem hiding this comment.
Does each router require it's own root route?
There was a problem hiding this comment.
No, each router does not require its root route. I've added it to provide a default response. It acts as an entry point for our API.
There was a problem hiding this comment.
Would they be a need to provide a default response seeing as when pointing the activity to it, you'll use the right url.
There was a problem hiding this comment.
ok so shall I replace it with something like /Pippy_AI_Assistant ?
I've made some comments, please write better commit messages, "Modified Fastapi code" isn't a great commit message and tells very little about the changes you made in the commit. |
|
Closing as it's stale and we did something else. |
@walterbender @chimosky This includes the FastApi framework for the RAG model of Pippy's AI assistant Fixes#1