Skip to content

Conversation

virgile-dev
Copy link
Collaborator

Purpose

To move a doc you have to be at least admin of the destination doc.
It was written editor in the alert banner.

Proposal

Change editor for administrator

External contributions

Thank you for your contribution! 🎉

Please ensure the following items are checked before submitting your pull request:

  • I have read and followed the contributing guidelines
  • I have read and agreed to the Code of Conduct
  • I have signed off my commits with git commit --signoff (DCO compliance)
  • I have signed my commits with my SSH or GPG key (git commit -S)
  • My commit messages follow the required format: <gitmoji>(type) title description
  • I have added a changelog entry under ## [Unreleased] section (if noticeable change)
  • I have added corresponding tests for new features or bug fixes (if applicable)

To move a doc you have to be at least admin of the destination doc

Signed-off-by: virgile-deville <[email protected]>
@virgile-dev
Copy link
Collaborator Author

In the making of the PR I was thinking that the current permission setting is confusing.
We allow editors to create sub-docs why not allow them to move docs inside a document where they are editors. I feel we should change the permissions not the message. @lunika

Copy link

Size Change: -10 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/b2b7044d/_buildManifest.js 0 B -888 B (removed) 🏆
apps/impress/out/_next/static/93e1037d/_buildManifest.js 889 B +889 B (new file) 🆕

compressed-size-action

@lunika
Copy link
Member

lunika commented Sep 16, 2025

In the making of the PR I was thinking that the current permission setting is confusing. We allow editors to create sub-docs why not allow them to move docs inside a document where they are editors. I feel we should change the permissions not the message. @lunika

True. But it depends on the target position maybe ? Should we allow the "Move to my docs" for editors too ?
We should probably take the time to think about other situation where an admin role is needed and you can already do more or less the same thing as an editor.

@AntoLC AntoLC added the bug Something isn't working label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants