š(frontend) prevent duplicate emoji when used as first character in tā¦ #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/1592-copy-paste-emoji-in-title
branch
2 times, most recently
from
5e4f415 to
7ed8ea5
Compare
|
Size Change: +66 B (0%) Total Size: 4.07 MB
|
Ovgodd
force-pushed
the
fix/1592-copy-paste-emoji-in-title
branch
2 times, most recently
from
0f4a14d to
135ea9a
Compare
ā¦itle ensures icon and title are visually distinct in sub-document headers Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/1592-copy-paste-emoji-in-title
branch
from
135ea9a to
99eb65d
Compare
AntoLC
reviewed
Nov 20, 2025
Collaborator
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
I don't have the feeling it is working as it should, the paste emoji does not open the picker when we click on it, and it does not display correctly on the tree:
| if (isTopRoot) { | ||
| const sanitizedTitle = updateDocTitle(doc, inputText); | ||
| setTitleDisplay(sanitizedTitle); | ||
| return sanitizedTitle; |
Collaborator
There was a problem hiding this comment.
The return does not seem necessary, same here:
Comment on lines
+30
to
+31
| const leadingSpacesLength = title.match(/^\s+/)?.[0]?.length ?? 0; | ||
| const trimmedStart = title.slice(leadingSpacesLength); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const leadingSpacesLength = title.match(/^\s+/)?.[0]?.length ?? 0; | |
| const trimmedStart = title.slice(leadingSpacesLength); | |
| const trimmedTitle = title.trimStart(); |
| doc, | ||
| emoji ? `${emoji} ${inputText}` : inputText, | ||
| ); | ||
| const { emoji: pastedEmoji } = getEmojiAndTitle(inputText); |
Collaborator
There was a problem hiding this comment.
Do we still need the second getEmojiAndTitle under ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix duplicated emoji when pasting an emoji at the beginning of a subādoc title. The pasted emoji must stay in the title and must not be turned into the subādoc icon.
issue : 1592
copypasteemojis.mp4
Proposal
getEmojiAndTitle