🔧(font) export Marianne font css #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to export the Marianne font CSS file so that users of our UI kit can easily include the font in their projects. This involves updating our package.json to include the font CSS file in the exports and ensuring that the font can be imported correctly in both CSS and JavaScript/TypeScript files.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In Docs for the moment we have to extract the Marianne font from the package to paste it to the public repository.
By exposing the css font, we can avoid that, and leverage the automatic bundling.
Proposal
We update our
package.jsonto include the font CSS file in the exports and ensuring that the font can be imported correctly in both CSS and JavaScript/TypeScript files.On the app side it would be imported like that: