Restructure table on mobile #3073
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 71d7b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +202 B (+0.03%) Total Size: 721 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
comparison-table-mobile
branch
from
81a8289 to
71d7b28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
=======================================
Coverage 88.19% 88.20%
=======================================
Files 239 239
Lines 13775 13786 +11
Branches 1848 1850 +2
=======================================
+ Hits 12149 12160 +11
Misses 1569 1569
Partials 57 57
🚀 New features to boost your workflow:
|
connor-baer
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-1047
Purpose
To allow more space to show call to actions in the comparison table in narrow viewports, we decided to adopt a different layout for showing features and their values on mobile.
Approach and changes
Hide first table header and RowHeader, reduce col span to 2 on mobile.
Definition of done