Bugfix: CVODE(S) Inequality Constraints #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
I like how this example clearly shows the performance improvement from using the prior solution when computing the step size reduction factor.
There was a problem hiding this comment.
This example, on the other hand, required significantly more work following the change. Do you know why (or is it just that the Roberts problems are incredibly "sensitive")?
There was a problem hiding this comment.
I really like the the change made this problem succeed, where before it had failed out with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update output files for LLNL/sundials#787