Open
Conversation
Hermanlrx
force-pushed
the
adds-solo-rpw-example
branch
2 times, most recently
from
d7d257a to
3fd09cc
Compare
Updates link to instrument information. Adds docstring examples for level 3 HFR and TNR data products. Reformats level 2 HFR example. Add changelog entry.
Hermanlrx
force-pushed
the
adds-solo-rpw-example
branch
from
3fd09cc to
b4ec312
Compare
5 tasks
samaloney
requested changes
Mar 27, 2026
Member
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
Changes look good
I'm surprised we don't see a test fail as sunpy-soar isn't in the project dependices, you'll nee to add it to the project.toml file
Contributor
Author
|
Thanks for having a look I think tox installs sunpy-soar for tests? Should it still be added to main project dependencies if it's only needed for tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates
RPWSpectrogramwith examples of how to download and plot the level 3 data. List of changes:-Updates link to instrument information.
-Adds docstring examples for level 3 HFR and TNR data products.
-Reformats level 2 HFR example.
See also #148
AI Assistance Disclosure
AI tools were used for: