Improve robustness by safely accessing metadata using dict.get#175
Open
tejasnarwade wants to merge 3 commits intosunpy:mainfrom
Open
Improve robustness by safely accessing metadata using dict.get#175tejasnarwade wants to merge 3 commits intosunpy:mainfrom
tejasnarwade wants to merge 3 commits intosunpy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves robustness in RPWSpectrogram by replacing direct dictionary access (
meta["instrument"]) withmeta.get("instrument").This prevents potential KeyError exceptions when the "instrument" key is missing, making the code more resilient to incomplete metadata.
This was small change but still i think prevention is better than cure so i pushed the pr
The behavior remains unchanged when the key is present.
PR Description
AI Assistance Disclosure
AI tools were used for: