Migrate to auth-go from gotrue-go
#25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to supabase-community#24 Update references from `gotrue-go` to `auth-go` in the codebase. * **client.go** - Update import paths to reference `auth-go` instead of `gotrue-go`. - Update the `Client` struct to use the `auth-go` client. - Update the `NewClient` function to initialize the `auth-go` client. - Update the `SignInWithEmailPassword`, `SignInWithPhonePassword`, `EnableTokenAutoRefresh`, `RefreshToken`, and `UpdateAuthSession` methods to use `auth-go` types and methods. * **client_test.go** - Update import paths to reference `auth-go` instead of `gotrue-go`. - Update the `NewClient` function calls to initialize the `auth-go` client. - Update the test functions (`TestFrom`, `TestRpc`, `TestStorage`, and `TestFunctions`) to use `auth-go` types and methods. * **go.mod** - Remove `gotrue-go` dependency. - Add `auth-go` dependency. * **README.md** - Update the features section to mention `auth-go` instead of `gotrue-go`. * **test/remote_client.go** - Update import paths to reference `auth-go` instead of `gotrue-go`. - Update the `NewClient` function call to initialize the `auth-go` client. - Update the `SignInWithEmailPassword` method call to use `auth-go` types and methods. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/supabase-community/supabase-go/issues/24?shareId=XXXX-XXXX-XXXX-XXXX).
akmalcm
reviewed
Nov 9, 2024
- Add email/phone signup and signin tests - Implement token refresh and session management tests - Add user info retrieval and logout tests - Update to use auth-go types and requests
|
@akmalcm how do we like the updates to this PR? |
|
This pull request includes multiple changes to the Supabase Go client, primarily focusing on updating the authentication integration and improving the codebase by removing unnecessary comments and making the code more concise. The most important changes include switching from Authentication Integration Update:
Codebase Improvements:
Test Suite Enhancements:
Dependency Updates:
Miscellaneous: |
akmalcm
approved these changes
Nov 20, 2024
| ) | ||
|
|
||
| func TestFrom(t *testing.T) { | ||
| client, err := supabase.NewClient(API_URL, API_KEY, nil) |
There was a problem hiding this comment.
Why prefer supa over supabase? The latter feels better to me.
There was a problem hiding this comment.
You're right. It was to quickly distinguish my old closet from a new revision.
|
What's blocking this change? |
|
It would be good to merge this PR if contributors are good with it. |
|
Merge this PR please 🙏 |
|
Please merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24
Update references from
gotrue-gotoauth-goin the codebase.client.go
auth-goinstead ofgotrue-go.Clientstruct to use theauth-goclient.NewClientfunction to initialize theauth-goclient.SignInWithEmailPassword,SignInWithPhonePassword,EnableTokenAutoRefresh,RefreshToken, andUpdateAuthSessionmethods to useauth-gotypes and methods.client_test.go
auth-goinstead ofgotrue-go.NewClientfunction calls to initialize theauth-goclient.TestFrom,TestRpc,TestStorage, andTestFunctions) to useauth-gotypes and methods.go.mod
gotrue-godependency.auth-godependency.README.md
auth-goinstead ofgotrue-go.test/remote_client.go
auth-goinstead ofgotrue-go.NewClientfunction call to initialize theauth-goclient.SignInWithEmailPasswordmethod call to useauth-gotypes and methods.For more details, open the Copilot Workspace session.