fix(analytic): DB_HOSTNAME correctly set to chart's db or external db host
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
washanhanzi
changed the title
DB_HOSTNAME correctly set to chart's db or external db host
|
This change is extremely helpful. It would be great to not have to patch it in!! |
|
I see it's quite a while for any new commit or merged PR. I think the PR will stay open for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The analytic service
DB_HOSTNAMEenv value now only comes from chart's db value. The external db host will be ignored.What is the new behavior?
Correctly use external db_hostname when it's available.
Fix #72