fix(storage): correct secret key reference for AWS_SECRET_ACCESS_KEY #119
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The Helm template for AWS_SECRET_ACCESS_KEY incorrectly references
.Values.secret.s3.secretRefKey.keyId instead of .Values.secret.s3.secretRefKey.accessKey.
This causes pods to pull the wrong key from the Kubernetes Secret and fail to authenticate to S3/MinIO.
What is the new behavior?
Additional context
Tested locally with helm template to confirm correct Secret key resolution.
This aligns the chart with expected AWS credential naming (keyId for AWS_ACCESS_KEY_ID, accessKey for AWS_SECRET_ACCESS_KEY).