change db into a StatefulSet #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the DB component into a stateful set. This avoid having two instances of the DB running *on the same data*, which can happen with a deployment (i.e., during an update/reconfiguration). Also, added a shutdown command to properly shut down the database, to prevent data corruption.
|
Any updates on this? @SimoneLazzaris |
|
Unfortunately, no news from the supabase development team. I'd like to have this patch applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the DB component into a stateful set. This avoid having two instances of the DB running on the same data, which can happen with a deployment (i.e., during an update/reconfiguration).
Also, added a shutdown command to properly shut down the database, to prevent data corruption.
What kind of change does this PR introduce?
The DB deployment is changed into a StatefulSet. Since there can only be one pod mounting and using the data volume at a time, the correct semantic is to use a StatefulSet.
What is the current behavior?
Using a deployment allows kubernetes to do rolling updates, which mean that a new pod is started on the same Persistent Volume while the old one is shutting down.
That can cause data corruption - which I've personally observed - when upgrading the helm chart.
What is the new behavior?
In the statefulset semantic, at most only one pod can be scheduled to run, so you don't have this issue.
I've also add a lifecycle command so that when the pod is shut down, postgres is commanded to shut down as well, so that it can close in a controlled fashion.