fix: use config.SiteURL instead of externalURL for send_email hook payload#2559
Open
yonatan-genai wants to merge 1 commit into
Open
fix: use config.SiteURL instead of externalURL for send_email hook payload#2559yonatan-genai wants to merge 1 commit into
yonatan-genai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2558.
The
send_emailhook payload'semail_data.site_urlis populated fromAPI_EXTERNAL_URL(e.g.https://<ref>.supabase.co/auth/v1) instead ofGOTRUE_SITE_URL(e.g.https://myapp.com).The SMTP template path gets this right —
{{ .SiteURL }}resolves fromGOTRUE_SITE_URL. The hook path doesn't, it pulls fromAPI_EXTERNAL_URLinstead.So if you're using the hook to build confirmation links from
site_url, they point to the auth server instead of your app. The field is calledsite_urlbut it's not the site URL.One-line fix:
externalURL.String()→config.SiteURL.