-
Notifications
You must be signed in to change notification settings - Fork 667
chore(ci): run tests against Multigres #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fadymak
wants to merge
2
commits into
master
Choose a base branch
from
fm/multigres-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Severity: LOW
The
latesttag is mutable and unpinned. If themultigresGitHub org or registry is compromised, a malicious image could be silently pushed and would execute arbitrary code in the CI runner — potentially exfiltrating repository secrets. The other service images in this workflow (postgres:15,orioledb/orioledb:beta16-pre-2-pg17) use pinned versions.Helpful? Add 👍 / 👎
💡 Fix Suggestion
Suggestion: Pin the
multigres-clusterimage to a specific immutable version tag or SHA256 digest instead of using:latest. First, identify the desired release version or obtain the current image digest by running:docker pull ghcr.io/multigres/multigres-cluster:latest && docker inspect --format='{{index .RepoDigests 0}}' ghcr.io/multigres/multigres-cluster:latest. Then replace:latestwith either a specific version tag (e.g.,ghcr.io/multigres/multigres-cluster:v0.1.2) or a full digest pin (e.g.,ghcr.io/multigres/multigres-cluster@sha256:<hash>). This follows the same pinning practice already used by the other service images in this workflow (postgres:15andorioledb/orioledb:beta16-pre-2-pg17).